Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove react from npm disctribution #11

Open
vaukalak opened this issue Jun 23, 2016 · 3 comments
Open

remove react from npm disctribution #11

vaukalak opened this issue Jun 23, 2016 · 3 comments

Comments

@vaukalak
Copy link

when installing from npm, there'e a directory node_modules/es6-react-mixins/node_modules/react/.

This cause @provideModule duplication issue (at least with react-native).

@angus-c
Copy link
Owner

angus-c commented Jul 2, 2016

this is expected and necessary - react is required by mixin.js

@vaukalak
Copy link
Author

vaukalak commented Jul 2, 2016

@angus-c you should add it as dependency in package.json. ok I'll fork that and will try to show you an example.

@angus-c
Copy link
Owner

angus-c commented Jul 2, 2016

It is already a dependency

  "dependencies": {
    "babel-runtime": "^5.8.25",
    "react": "^0.13.3"
  },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants