Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using a bad element name, the loading indicator is shown indefinitely instead of the error indicator #74

Open
lbilger opened this issue Jan 27, 2021 · 6 comments

Comments

@lbilger
Copy link

lbilger commented Jan 27, 2021

I have created an example at https://stackblitz.com/edit/angular-extensions-elements-loading?file=src/app/app.component.html

If the element I am trying to reference is not included in the specified URL, I would expect an error message (as I get when the URL itself is bad), but I get the loading indicator.

@lbilger lbilger changed the title When using a bad element name, the loading indicator is shown indefinit When using a bad element name, the loading indicator is shown indefinitely instead of the error indicator Jan 27, 2021
@arturovt
Copy link
Collaborator

Hey @lbilger . I see there's error template has been created and not the loading one:

image

Could you tell me if I'm missing anythig?

@lbilger
Copy link
Author

lbilger commented Jun 16, 2021

Hi @arturovt, thanks for having a look! I had tried this only in Safari, but now that you said it works for you, I noticed that it works in Chrome but not in Safari.

@arturovt
Copy link
Collaborator

Ok, need to find my Mac to try it out in Safari 😄 Will get back to you with info soon!

@tomastrajan
Copy link
Member

@lbilger library, did NOT work with Stackblitz in the past much because of their service worker setup, did that change?

@lbilger
Copy link
Author

lbilger commented Jun 17, 2021

I saw no other problems and it seems to work in Chrome, but of course it’s a very minimal example. I noticed the problem in my real application, though. Stackblitz seemed the simplest way to create an example to reproduce it.

@finnMasurat
Copy link

Hello,
the issue still seems to be open.
It looks like the code is waiting for the whenDefined function to return the existing element. (

)

As this function itself is not throwing an error or has a timeout included, the code gets stuck there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants