forked from apache/datafusion
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add test to prevent circular dependencies from being added (apache#9292)
- Loading branch information
Showing
4 changed files
with
524 additions
and
180 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| /// Check for circular dependencies between DataFusion crates | ||
| use std::collections::{HashMap, HashSet}; | ||
| use std::env; | ||
| use std::path::Path; | ||
|
|
||
| use cargo::util::config::Config; | ||
| #[test] | ||
| fn test_deps() -> Result<(), Box<dyn std::error::Error>> { | ||
| let config = Config::default()?; | ||
| let path = env::var("CARGO_MANIFEST_DIR").unwrap(); | ||
| let dir = Path::new(&path); | ||
| let root_cargo_toml = dir.join("Cargo.toml"); | ||
| let workspace = cargo::core::Workspace::new(&root_cargo_toml, &config)?; | ||
| let (_, resolve) = cargo::ops::resolve_ws(&workspace)?; | ||
|
|
||
| let mut package_deps = HashMap::new(); | ||
| for package_id in resolve | ||
| .iter() | ||
| .filter(|id| id.name().starts_with("datafusion")) | ||
| { | ||
| let deps: Vec<String> = resolve | ||
| .deps(package_id) | ||
| .filter(|(package_id, _)| package_id.name().starts_with("datafusion")) | ||
| .map(|(package_id, _)| package_id.name().to_string()) | ||
| .collect(); | ||
| package_deps.insert(package_id.name().to_string(), deps); | ||
| } | ||
|
|
||
| // check for circular dependencies | ||
| for (root_package, deps) in &package_deps { | ||
| let mut seen = HashSet::new(); | ||
| for dep in deps { | ||
| check_circular_deps(root_package, dep, &package_deps, &mut seen); | ||
| } | ||
| } | ||
|
|
||
| Ok(()) | ||
| } | ||
|
|
||
| fn check_circular_deps( | ||
| root_package: &str, | ||
| current_dep: &str, | ||
| package_deps: &HashMap<String, Vec<String>>, | ||
| seen: &mut HashSet<String>, | ||
| ) { | ||
| if root_package == current_dep { | ||
| panic!( | ||
| "circular dependency detected from {root_package} to self via one of {:?}", | ||
| seen | ||
| ); | ||
| } | ||
| if seen.contains(current_dep) { | ||
| return; | ||
| } | ||
| seen.insert(current_dep.to_string()); | ||
| if let Some(deps) = package_deps.get(current_dep) { | ||
| for dep in deps { | ||
| check_circular_deps(root_package, dep, package_deps, seen); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.