Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson: write test for pkg-config based extension builds #58

Open
anarazel opened this issue Aug 9, 2022 · 2 comments
Open

meson: write test for pkg-config based extension builds #58

anarazel opened this issue Aug 9, 2022 · 2 comments
Assignees

Comments

@anarazel
Copy link
Owner

anarazel commented Aug 9, 2022

We now generate postgresql-extension.pc and postgresql-extension-warnings-uninstalled.pc, containing the correct flags to build an extension fairly easily, without otherwise using postgres' build infrastructure. I manually tested this on linux and windows, but we should have automated tests for this.

Likely just as part of our normal testsuite. If we do that, it might also be worth writing a test for building the same extension via pgxs.

My manual tests were just:
build against (pseudo-)installed postgres:

PKG_CONFIG_SYSROOT_DIR=/tmp/meson/tmp_install PKG_CONFIG_PATH=/tmp/meson/tmp_install/tmp/meson-install/lib/x86_64-linux-gnu/pkgconfig/ m setup build 
ninja -C build -v

build against postgres build tree:

PKG_CONFIG_PATH=/tmp/meson/meson-uninstalled m setup build --wipe && ninja -C build -v
ninja -C build -v

on windows with msvc it likely would be worth testing both --buildtype vs and --buildtype ninja

@anarazel anarazel mentioned this issue Aug 9, 2022
64 tasks
@nbyavuz nbyavuz self-assigned this Aug 16, 2022
@nbyavuz
Copy link
Collaborator

nbyavuz commented Sep 13, 2022

Likely just as part of our normal testsuite.

Did you mean adding these tests to the current testsuite implementation or adding these tests to '.cirrus.yml' as a 'script'?

@anarazel
Copy link
Owner Author

Did you mean adding these tests to the current testsuite implementation or adding these tests to '.cirrus.yml' as a 'script'?

The former.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants