Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in unload.py #358

Open
MM-Lehmann opened this issue Dec 17, 2024 · 1 comment · May be fixed by #359
Open

Typo in unload.py #358

MM-Lehmann opened this issue Dec 17, 2024 · 1 comment · May be fixed by #359
Assignees
@oguzhanbsolak

Comments

@MM-Lehmann
Copy link

ai8x-synthesis/izer/unload.py

Lines 519 to 521 in 1411cb1

out_text += f'(int{o_width*2}_t)((val'
else:
out_text += f'(int{o_width*2}_t)(((val >> {shift * 8})'

One additional opening bracket produces invalid C code as it is not matched by a corresponding closing bracket. I propose to delete one bracket in lines 519 and 521, col 77.
@oguzhanbsolak oguzhanbsolak self-assigned this Dec 19, 2024
@oguzhanbsolak oguzhanbsolak linked a pull request Dec 19, 2024 that will close this issue
Open
@oguzhanbsolak
Copy link
Contributor

Hi! Thanks for letting us know about the issue. We need the extra bracket for the case a layer with a negative final scale. It seems like we missed a condition for the case when layers with non-zero scales and zero scales coexist. With the #359, it will be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oguzhanbsolak oguzhanbsolak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for --scale-output with a zero final scale layer oguzhanbsolak/ai8x-synthesis
2 participants
@MM-Lehmann @oguzhanbsolak