Dynamic notices not updating if we use nav bar search to open another table

[mikaalanwar]

Dynamic notices are not updated/changed if we use the "nav bar" search at the top to open another table. However, if we navigate to another page (e.g. search or home page etc.) and then choose another table, the dynamic notices do get updated. In the network tab in Chrome Debugging Tools, it can be observed that an explicit web request is not sent to the Notices API in the former case, however, it is sent in the latter, having a URL similar to the one given below:

http://localhost:5000/api/notices/v0/table?resource=table&key=TABLE_PATH

Expected Behavior

Dynamic notices should be updated whenever we open the table detail page for a different table (regardless of whether we traversed from the home page or went from one table detail page to another using the search box in the navigation bar at the top).

Current Behavior

Dynamic notices are not updated/changed if we use the "nav bar" search at the top to open another table.

Possible Solution

React code is updated in such a way that it triggers the request every time the table detail page is changed (i.e. we go from the table detail page for one table to another).

Steps to Reproduce

1. Configure dynamic notices (by adding a notice client and enabling it in settings) for Amundsen.
2. Open the table detail page for any table.
3. Now navigate to another table detail page using the nav bar search at the top.
4. You will notice that the dynamic notices are not updated. This can be cross-checked via Chrome debugger.

Screenshots (if appropriate)

N/A

Context

We are unable to use a critical feature that heavily leverages the dynamic notices in Amundsen.

Your Environment

• Amundsen version used: 00377a3
• Data warehouse stores: BigQuery
• Deployment (k8s or native): k8s
• Link to your fork or repository: https://github.com/deliveryhero/amundsen

[mikaalanwar]

Closing this as the issue was fixed by the pull request #2210