diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index dc34752f95..370bfe2a6e 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -14,7 +14,7 @@ /amundsen-kube-helm/ @feng-tao @jornh @javamonkey79 common/*.py @feng-tao @jinhyukchang @allisonsuarez @verdan @bolkedebruin @mgorsk1 @dorianj -databuilder/*.py @feng-tao @jinhyukchang @allisonsuarez @dikshathakur3119 @dorianj @verdan +databuilder/*.py @feng-tao @jinhyukchang @allisonsuarez @dikshathakur3119 @dorianj @verdan @mgorsk1 frontend/amundsen_application/static/ @Golodhros @ttannis @allisonsuarez @dikshathakur3119 @feng-tao @dorianj frontend/*.py @ttannis @feng-tao @dikshathakur3119 @allisonsuarez @dorianj @verdan metadata/*.py @feng-tao @jinhyukchang @allisonsuarez @dikshathakur3119 @verdan @bolkedebruin @mgorsk1 diff --git a/databuilder/databuilder/extractor/dashboard/apache_superset/apache_superset_extractor.py b/databuilder/databuilder/extractor/dashboard/apache_superset/apache_superset_extractor.py index 792a3bc628..cd399019f7 100644 --- a/databuilder/databuilder/extractor/dashboard/apache_superset/apache_superset_extractor.py +++ b/databuilder/databuilder/extractor/dashboard/apache_superset/apache_superset_extractor.py @@ -51,7 +51,7 @@ class ApacheSupersetBaseExtractor(Extractor): APACHE_SUPERSET_PORT: '8088', APACHE_SUPERSET_PAGE_SIZE: 20, APACHE_SUPERSET_EXTRACT_PUBLISHED_ONLY: False, - PRODUCT: 'apache_superset', + PRODUCT: 'superset', DASHBOARD_GROUP_DESCRIPTION: '', DRIVER_TO_DATABASE_MAPPING: DEFAULT_DRIVER_TO_DATABASE_MAPPING, DATABASE_TO_CLUSTER_MAPPING: {} diff --git a/databuilder/tests/unit/extractor/dashboard/apache_superset/test_apache_superset_chart_extractor.py b/databuilder/tests/unit/extractor/dashboard/apache_superset/test_apache_superset_chart_extractor.py index 3ceff9ae2d..948e1ae160 100644 --- a/databuilder/tests/unit/extractor/dashboard/apache_superset/test_apache_superset_chart_extractor.py +++ b/databuilder/tests/unit/extractor/dashboard/apache_superset/test_apache_superset_chart_extractor.py @@ -74,7 +74,7 @@ def test_extractor(self) -> None: self.assertIsInstance(record, DashboardQuery) self.assertEqual(record._query_name, 'default') self.assertEqual(record._query_id, '-1') - self.assertEqual(record._product, 'apache_superset') + self.assertEqual(record._product, 'superset') self.assertEqual(record._cluster, 'gold') record = extractor.extract() diff --git a/databuilder/tests/unit/extractor/dashboard/apache_superset/test_apache_superset_metadata_extractor.py b/databuilder/tests/unit/extractor/dashboard/apache_superset/test_apache_superset_metadata_extractor.py index d082103e64..dfbc2f02de 100644 --- a/databuilder/tests/unit/extractor/dashboard/apache_superset/test_apache_superset_metadata_extractor.py +++ b/databuilder/tests/unit/extractor/dashboard/apache_superset/test_apache_superset_metadata_extractor.py @@ -60,7 +60,7 @@ def test_extractor(self) -> None: self.assertEqual(record.dashboard_name, 'dashboard name') self.assertEqual(record.description, '') self.assertEqual(record.cluster, 'gold') - self.assertEqual(record.product, 'apache_superset') + self.assertEqual(record.product, 'superset') self.assertEqual(record.dashboard_group_id, '1') self.assertEqual(record.dashboard_id, '2') self.assertEqual(record.dashboard_group_description, 'dashboard group description') @@ -74,5 +74,5 @@ def test_extractor(self) -> None: self.assertEqual(record._dashboard_group_id, '1') self.assertEqual(record._dashboard_id, '2') self.assertEqual(record._last_modified_timestamp, 1620981665) - self.assertEqual(record._product, 'apache_superset') + self.assertEqual(record._product, 'superset') self.assertEqual(record._cluster, 'gold') diff --git a/frontend/amundsen_application/static/css/_icons.scss b/frontend/amundsen_application/static/css/_icons.scss index 3acd091a7a..26ebf7c9b1 100644 --- a/frontend/amundsen_application/static/css/_icons.scss +++ b/frontend/amundsen_application/static/css/_icons.scss @@ -29,6 +29,7 @@ $dashboards: ( mode: '../images/icons/logo-mode.svg', redash: '../images/icons/logo-redash.svg', tableau: '../images/icons/logo-tableau.svg', + superset: '../images/icons/logo-superset.svg', ); // Map of User names and icon paths diff --git a/frontend/amundsen_application/static/images/icons/logo-superset.svg b/frontend/amundsen_application/static/images/icons/logo-superset.svg new file mode 100644 index 0000000000..452bce3245 --- /dev/null +++ b/frontend/amundsen_application/static/images/icons/logo-superset.svg @@ -0,0 +1,11 @@ + + superset + + + + + + diff --git a/frontend/amundsen_application/static/js/config/config-default.ts b/frontend/amundsen_application/static/js/config/config-default.ts index 833f6dc739..5de7ea269b 100644 --- a/frontend/amundsen_application/static/js/config/config-default.ts +++ b/frontend/amundsen_application/static/js/config/config-default.ts @@ -71,6 +71,10 @@ const configDefault: AppConfig = { displayName: 'Tableau', iconClass: 'icon-tableau', }, + superset: { + displayName: 'Superset', + iconClass: 'icon-superset', + }, }, filterCategories: [ { diff --git a/frontend/amundsen_application/static/js/interfaces/Enums.ts b/frontend/amundsen_application/static/js/interfaces/Enums.ts index b34ebc1a0f..491e63e88c 100644 --- a/frontend/amundsen_application/static/js/interfaces/Enums.ts +++ b/frontend/amundsen_application/static/js/interfaces/Enums.ts @@ -62,6 +62,7 @@ export enum IconType { POSTGRES = 'icon-postgres', REDSHIFT = 'icon-redshift', SNOWFLAKE = 'icon-snowflake', + SUPERSET = 'icon-superset', } // Icon sizes