Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MKV Video Failing MediaConch GUI Ex. policy #857

Closed
SoFrans opened this issue Dec 3, 2024 · 9 comments · Fixed by MediaArea/MediaConch_SourceCode#791
Closed

MKV Video Failing MediaConch GUI Ex. policy #857

SoFrans opened this issue Dec 3, 2024 · 9 comments · Fixed by MediaArea/MediaConch_SourceCode#791

Comments

@SoFrans
Copy link

SoFrans commented Dec 3, 2024

Hi,

I was wondering if anyone has run into this problem as well. When I put a MKV file that was generated with VRecord into MediaConch to run the report (Example MKV FFV1 digitization policy), it fails. The point of failure is the Display Aspect Ratio, MediaConch wants it to be 4/3, however the actual value that is being reported is 1.347 (I have 4:3 selected in VRecord). I know that this is negligible, but is there a way to get a true 4:3 so it doesn't fail the policy check?

Thanks,
Sophia

@SoFrans
Copy link
Author

SoFrans commented Dec 3, 2024

Also apparently the access files are getting a display aspect ratio of 3:2 and that doesn't seem right to me...
(sorry we are switching from uncompressed to FFV1 native capture so I'm being very careful with the transition).

@dericed
Copy link
Member

dericed commented Dec 3, 2024

Hi @SoFrans, this issue was fixed in 5b9fa8b. We had added some fine-tuning for display aspect ratio but forgot to support that in the mediaconch test. I think if you update vrecord, you'll find the issue resolved. The 3:2 DAR issue sounds unexpected though, was the access file made by vrecord?

@SoFrans
Copy link
Author

SoFrans commented Dec 3, 2024

Hi Dave,

The access file was made in VRecord. I have multiple that seem to be showing that 3:2 DAR for the access copies. Happy to share the MediaInfo report with you if need be.

So the display aspect ratio bit for FFV1 even though it is failing in the MediaConch GUI is fine? If so great.

Thanks,
Sophia

@SoFrans
Copy link
Author

SoFrans commented Dec 3, 2024

I just checked and the height and width of the video is what it should be, but for whatever reason the DAR is wrong...

@dericed
Copy link
Member

dericed commented Dec 3, 2024

can you send along the ffmpeg log for this capture?

Also see this discussion for the background on vrecord changing it's approach to aspect ratio: #689

@SoFrans
Copy link
Author

SoFrans commented Dec 4, 2024

Hi Dave,

Here is the capture_options log. The only thing that I have tweaked in the settings is for CBR to be VBR as that is what is required for files where I work.

p0479_gree_99-1520192420-2441_v01_p_capture_options.log

@dericed
Copy link
Member

dericed commented Dec 7, 2024

Hi @SoFrans, I'm realizing that to fix this issue we'd need to adjust Mediaconch rather than vrecord. The mediaconch policy that is stored within vrecord is already updated for this but a similar one in Mediaconch is not. That lives at https://github.com/MediaArea/MediaConch_SourceCode/blob/b0b89e4a6e61f2c4dc1df935e668296f558a5f7f/Tools/Policies/sample_policy_4_output.xml#L13.

I'm considering how to update that as either we could:

  • remove the test there altogether
  • update it to test for a range of display aspect ratio range than just 1.333. Like maybe 1.316...1.350 since that's the range covered by the options now in vrecord for 4/3.

@dericed
Copy link
Member

dericed commented Dec 9, 2024

Hi @SoFrans this is partly fixed in MediaArea/MediaConch_SourceCode#791. Here the example MediaConch policy you mentioned is updated to consider the range used for 4/3 video vrecord. The other issue you mentioned about the aspect ratio of the mp4 is addressed in #858 but some comments are needed there.

@dericed
Copy link
Member

dericed commented Dec 9, 2024

will close as this is fixed in #858 and MediaArea/MediaConch_SourceCode#791. Thanks @SoFrans, this should all work in the next releases of MediaConch and Vrecord.

@dericed dericed closed this as completed Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants