New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XHR error callback & empty data #12

Open

appbak3r opened this issue Dec 9, 2015 · 1 comment

appbak3r commented Dec 9, 2015

Error callback only working if 404 status sent https://github.com/amcharts/dataloader/blob/master/dataloader.js#L477

Maybe the right way is to use 200 and 302 HTTP codes for success and others for failure?

Also if there is no data from response amcharts just throws an error. It will be good if error function will be called here.

Collaborator

martynasma commented Dec 9, 2015

Both are very reasonable points. We'll definitely consider it.

Thanks!

appbak3r mentioned this issue

Use 200 and 302 HTTP codes for success and others for failure #13

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment