Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor generate_qr.py with Error Handling and Modularization #5

Closed
Amansingh0807 opened this issue Jan 1, 2025 · 4 comments
Closed
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers SWOC

Comments

@Amansingh0807
Copy link
Contributor

Summary:

The script has been refactored to include:

- Error Handling: Checks if the input file exists before processing. Raises a FileNotFoundError with a clear message if the file is missing.
- Modularization: Split the code into functions for better readability and maintainability.
- Improved Feedback: Provides clear messages about the process and errors.

Benefits:

  • Prevents silent failures.
  • Makes the code cleaner and easier to extend.
  • Improves user experience with better error messages.
@amanraox amanraox added enhancement New feature or request good first issue Good for newcomers SWOC swoc2025 labels Jan 1, 2025
@amanraox
Copy link
Owner

amanraox commented Jan 1, 2025

go ahead @Amansingh0807 !

@amanraox
Copy link
Owner

amanraox commented Jan 1, 2025

btw i have noticed we have same name 😁

@Amansingh0807
Copy link
Contributor Author

btw i have noticed we have same name 😁

Oo yes, we both have same name 😊😊

@amanraox amanraox closed this as completed Jan 2, 2025
Copy link

github-actions bot commented Jan 2, 2025

✅ This issue has been successfully closed. Thank you for your contribution and helping us improve the project! If you have any more ideas or run into other issues, feel free to open a new one. Happy coding! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers SWOC
Projects
None yet
Development

No branches or pull requests

2 participants