Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dot Not replace IMG tag by Md reference when image is nested into other HTML tags #48

Open
alxnbl opened this issue Dec 13, 2021 · 2 comments
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed

Comments

@alxnbl
Copy link
Owner

alxnbl commented Dec 13, 2021

Describe the bug

PanDoc post-processing replace IMG tag into Md References.

This post-processing should not replace IMG tab that are nested into other HTML tags like TABLE. Because MD references nested into HTML tags are not interpreted by Md readers.

@alxnbl alxnbl added the bug Something isn't working label Dec 13, 2021
@alxnbl alxnbl changed the title Dot Not replace IMG tag by Md reference where image is part of an HTML object (like Table) Dot Not replace IMG tag by Md reference when image is nested into other HTML tags Dec 13, 2021
@alxnbl alxnbl added enhancement New feature or request bug Something isn't working and removed bug Something isn't working enhancement New feature or request labels Oct 25, 2022
@alxnbl alxnbl added the enhancement New feature or request label Sep 22, 2023
@alxnbl alxnbl added the help wanted Extra attention is needed label Aug 15, 2024
@alxnbl
Copy link
Owner Author

alxnbl commented Aug 15, 2024

In certain situations, Padoc converts Docx tables into Html because it does't manage to translate the content into markdown. But if the html table contains an image tag, the OneNoteExport translate it into markdown.

Html tags are supported inside mardown, but markdown is not supported inside html. rmarkdown. Which thus prevent the image to display.

An evolution of the code that replace html img tags is required to avoid replacement of img tags nested into an other html tag (or at least table tag). Maybe one generous contributor will take care of the evolution, or me but not in a near futur.

@alxnbl
Copy link
Owner Author

alxnbl commented Aug 15, 2024

Location in the code : ExtractImagesToResourceFolder function in file https://github.com/alxnbl/onenote-md-exporter/blob/main/src/OneNoteMdExporter/Services/Export/ExportServiceBase.cs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant