Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A small thing... #112

Open
bobhalford opened this issue Nov 23, 2024 · 1 comment
Open

A small thing... #112

bobhalford opened this issue Nov 23, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bobhalford
Copy link

bobhalford commented Nov 23, 2024

First up, thanks for all your work on this. Very nice. However, I did spend quite a few hours trying to solve a problem - your app worked nicely on all but one page in a particular notebook. If I had been working late (or post midnight as is often the case) I might not have noticed that one out of many pages had been ignored. So may I suggest a bit more "in-your_face" message as the last console line output - preferably in red - warning of lost page(s)? The other thing - the message error 0x80042006 didn't really tell me much - even with the help of chatgpt. The page exported to mht just fine manually in onenote.. the content was no longer than other pages that went fine. Eventually I found the exception source at line 43 in temporarynotebooks.cs. I guessed one of the arguments to a onenote interop method was off... they all looked good.... except the OneNotePath looked pretty long. On a hunch I moved the solution folder down closer to the drive root... and the problem went away. I think if you added a tiny bit of code to check for reasonable windows friendly filepath lengths it might save a lot of folks some grief.. and maybe add a bit more info in the log? Just saying.. thanks again.. very useful tool! Bob

PS Oh, BTW there were a couple of items that vs complained about but that can be easily fixed by updating to slightly later packages...so, might want to fix and update release... "Package 'System.Private.Uri' 4.3.0 has a known high severity vulnerability, GHSA-5f2m-466j-3848"

@alxnbl
Copy link
Owner

alxnbl commented Nov 23, 2024

Thank you for your pertinent feedback @bobhalford ! The max length limitation of file path is a known limitation and it would clearly justify a warning.
I will try to improve these points theses points in the next release. But probably not before a cupple of weeks.

@alxnbl alxnbl added enhancement New feature or request good first issue Good for newcomers labels Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants