Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch network errors during download-dat #70

Closed
TylerVigario opened this issue Feb 3, 2023 · 2 comments
Closed

Catch network errors during download-dat #70

TylerVigario opened this issue Feb 3, 2023 · 2 comments

Comments

@TylerVigario
Copy link
Contributor

TylerVigario commented Feb 3, 2023 •
edited
Loading

Got an error during updating my Redump DATs today.

Processing "Sony - PlayStation 2"
⠠
thread 'main' panicked at 'Failed to download ZIP: connection closed', src/download_dats.rs:270:10
@TylerVigario TylerVigario changed the title Improve download-dat network error resilience Catch network errors during download-dat Feb 3, 2023
@alucryd
Copy link
Owner

alucryd commented Feb 3, 2023 •
edited
Loading

I was being lazy here because surf's error does not have the StdError trait, which makes it a pain to handle :P I'll see what I can do.

Edit: There's even an issue about it upstream http-rs/surf#347

@alucryd
Copy link
Owner

alucryd commented Feb 3, 2023

Done, it will simply progress to the next DAT now :)

@alucryd alucryd closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TylerVigario @alucryd