Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter-out results that do not match the search query #6

Open
almog opened this issue Apr 14, 2023 · 0 comments
Open

Filter-out results that do not match the search query #6

almog opened this issue Apr 14, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@almog
Copy link
Owner

almog commented Apr 14, 2023

Even after removing the "suggested items" (which ebay might serve on no exact match), I've noticed that occasionally ebay some results that should have been part of an exact match simply sneak past some search operator, especially the NOT (minus) operator.

By parsing the search query and filtering out every result that that does not match, we can not only avoid the above but also remove brittle (and language dependent) code that deals with "suggested items" (as well as some of the css-specificity, which targets the search results while avoiding other items on the page, though I might opt to keep that until proven to be brittle).

@almog almog added the enhancement New feature or request label Apr 18, 2023
@almog almog changed the title Validate each item against ebay search query Filter-out results that do not match the search query Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant