chore(rpc-types): Buildable Type #374
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📚
|
|
Needs review from @emhane |
emhane
requested changes
Jan 9, 2025
| Some(TxType::Eip1559) => Some(OpTxType::Eip1559), | ||
| Some(TxType::Eip2930) => Some(OpTxType::Eip2930), | ||
| Some(TxType::Eip7702) => Some(OpTxType::Eip7702), | ||
| Some(TxType::Eip4844) => Some(OpTxType::Eip1559), |
There was a problem hiding this comment.
how did you think here, eip4844 -> eip1559 ? I would have thought that variant is just skipped, possibly with a debug log message that eip4844 isn't supported for eip4844
There was a problem hiding this comment.
We can do that - was pretty unsure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #29.
Implements the
buildable_typemethod on theOpTransactionReceipttype.