Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Impl TransactionRequest::preferred_type for new type OpTransactionRequest #28

Open
emhane opened this issue Jul 28, 2024 · 1 comment · May be fixed by #375
Open

[Feature] Impl TransactionRequest::preferred_type for new type OpTransactionRequest #28

emhane opened this issue Jul 28, 2024 · 1 comment · May be fixed by #375

Comments

@emhane
Copy link
Collaborator

emhane commented Jul 28, 2024 •
edited
Loading

Component

rpc

Describe the feature you would like

Impl OpTransactionRequest::preferred_type which should cover OpTxType::Deposit variant.

https://github.com/alloy-rs/alloy/blob/a33937d9f4a1c67d5ea06e8eb9ad443ffde900f7/crates/rpc-types-eth/src/transaction/request.rs#L519-L539

Additional context

Blocked by #27

No response
@emhane emhane added the C-blocked Category: This cannot move forward until something else changes label Jul 28, 2024
@emhane emhane removed the C-blocked Category: This cannot move forward until something else changes label Nov 29, 2024
@emhane
Copy link
Collaborator Author

emhane commented Nov 29, 2024

actually, do we need to rebuild the whole OpTransactionRequest type: add deposit remove 4844? @refcell

@refcell refcell linked a pull request Jan 9, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(rpc-types): Preferred Type alloy-rs/op-alloy
1 participant
@emhane