Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VERSION in Makefile is wrong when used with non-annotated git tags #751

Open
qezz opened this issue Feb 18, 2025 · 0 comments
Open

VERSION in Makefile is wrong when used with non-annotated git tags #751

qezz opened this issue Feb 18, 2025 · 0 comments

Comments

@qezz
Copy link

qezz commented Feb 18, 2025

v0.8.3 is not annotated tag so the VERSION variable in the Makefile always fails

# don't override user values
ifeq (,$(VERSION))
  VERSION := $(shell git describe --exact-match 2>/dev/null)
  # if VERSION is empty, then populate it with branch's name and raw commit hash
  ifeq (,$(VERSION))
    VERSION := $(BRANCH)-$(COMMIT)
  endif
endif
source/allora-network/allora-chain (tags/v0.8.3?) $ git describe --exact-match
fatal: no tag exactly matches 'cab7882d7d460813c0424b155b8f77979a3c4007'

non-annotated tags are generally not recommended, but if you want to make them work, you need to provide --tags

allora-network/allora-chain (tags/v0.8.3?) $ git describe --exact-match --tags
v0.8.3

It's up to you how to approach this issue. A workaround patch is in the #750

https://git-scm.com/book/en/v2/Git-Basics-Tagging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant