Skip to content
This repository has been archived by the owner on Mar 24, 2021. It is now read-only.

Consistent loading state and error handling #253

Open
ragingsquirrel3 opened this issue Mar 27, 2017 · 1 comment
Open

Consistent loading state and error handling #253

ragingsquirrel3 opened this issue Mar 27, 2017 · 1 comment
Labels

Comments

@ragingsquirrel3
Copy link
Contributor

Make loading indicator and error handling consistent across pages. The gene page does very rudimentary error handling and the search results page appears to fail silently in certain cases. Both pages use different loading indicators. It would be good to sort this out before we start adding too many more types of pages.

@ragingsquirrel3
Copy link
Contributor Author

there is a component which I initially designed to give a nice looking, general loading look at https://github.com/alliance-genome/agr/blob/development/src/js_src/components/loadingPage.js, which the search pages renders in place of the content whenever the search is loading. This should be used on any page, whenever the entire page is pending. In the searchReducer, there is a boolean for isPending, so maybe that value could be moved into a more general reducer.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant