Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execErr seems to be ignored other than for exit code #20

Open
jose-fully-ported opened this issue Oct 26, 2023 · 0 comments · May be fixed by #21
Open

execErr seems to be ignored other than for exit code #20

jose-fully-ported opened this issue Oct 26, 2023 · 0 comments · May be fixed by #21

Comments

@jose-fully-ported
Copy link

Expected Behaviour

I would expect us to do something with execErr here unless it can truly be ignored, but its not clear if it can be.

Current Behaviour

execErr is dropped on the floor if its not an exit error.

Possible Solution

Return it if ctx.Err() is nil?

Steps to Reproduce (for bugs)

N/A

Context

Just curious as to whether ignoring it is the correct thing to do.

Your Environment

  • go version : go version go1.21.3 darwin/arm64

  • Operating System and version (e.g. Linux, Windows, MacOS): MacOS Ventura 13.6

  • Link to your project or a code example to reproduce issue: N/A

@josegonzalez josegonzalez linked a pull request Jan 13, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant