From 3917f981b1d5f7f02c5dcbf23786ed5e554f9b66 Mon Sep 17 00:00:00 2001 From: Alec Thomas Date: Thu, 6 Sep 2018 10:27:08 +1000 Subject: [PATCH] Update install.sh + README. Ideally we could check in CI that the generated godownloader script doesn't differ from script/install.sh, but godownloader is currently broken (https://github.com/goreleaser/godownloader/issues/81). Fixes #525. Fixes #526. --- README.md | 13 +++++-------- scripts/install.sh | 4 ++-- 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/README.md b/README.md index e3f5c558..e2881a0d 100644 --- a/README.md +++ b/README.md @@ -45,13 +45,11 @@ It is intended for use with editor/IDE integration. ## Installing -There are two options for installing gometalinter. +To install the latest stable release: -1. Install a stable version, eg. `go get -u gopkg.in/alecthomas/gometalinter.v2`. - I will generally only tag a new stable version when it has passed the Travis - regression tests. The downside is that the binary will be called `gometalinter.v2`. -2. Install from HEAD with: `go get -u github.com/alecthomas/gometalinter`. - This has the downside that changes to gometalinter may break. + curl https://git.io/vp6lP | sh + +Alternatively you can install a specific version from the [releases](https://github.com/alecthomas/gometalinter/releases) list. ## Editor integration @@ -334,8 +332,7 @@ are three things to try in that case: #### 1. Update to the latest build of gometalinter and all linters - go get -u github.com/alecthomas/gometalinter - gometalinter --install + curl https://git.io/vp6lP | sh If you're lucky, this will fix the problem. diff --git a/scripts/install.sh b/scripts/install.sh index 84f92a2e..084ec214 100755 --- a/scripts/install.sh +++ b/scripts/install.sh @@ -1,6 +1,6 @@ #!/bin/sh set -e -# Code generated by godownloader on 2018-05-08T08:53:30Z. DO NOT EDIT. +# Code generated by godownloader on 2018-09-06T00:26:55Z. DO NOT EDIT. # usage() { @@ -51,7 +51,7 @@ execute() { rm -rf "${srcdir}" (cd "${tmpdir}" && untar "${TARBALL}") install -d "${BINDIR}" - for binexe in "gometalinter" "gocyclo" "nakedret" "misspell" "govet" "gosec" "golint" "ineffassign" "goconst" "errcheck" "maligned" "unconvert" "dupl" "structcheck" "varcheck" "safesql" "deadcode" "lll" "goimports" "gotype" "gosimple" "megacheck" "staticcheck" "unused" "interfacer" "unparam" ; do + for binexe in "gometalinter" "gocyclo" "nakedret" "misspell" "gosec" "golint" "ineffassign" "goconst" "errcheck" "maligned" "unconvert" "dupl" "structcheck" "varcheck" "safesql" "deadcode" "lll" "goimports" "gotype" "gosimple" "megacheck" "staticcheck" "unused" "interfacer" "unparam" "gochecknoinits" "gochecknoglobals" ; do if [ "$OS" = "windows" ]; then binexe="${binexe}.exe" fi