Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using six-group.com as source for automatic updates #30

Open
courtney-miles opened this issue Sep 13, 2022 · 3 comments
Open

Using six-group.com as source for automatic updates #30

courtney-miles opened this issue Sep 13, 2022 · 3 comments

Comments

@courtney-miles
Copy link

courtney-miles commented Sep 13, 2022

Would the package maintainers be interested in a PR that scripts the updating of the codes in this package?

The idea would be to use SIX Financial Information as the source.

SIX Financial Information AG is the official Maintenance Agency of these currency codes under ISO 4217 and as such the only recognized, authoritative source on currency code designations.

They offer and XML copy of all the code current codes at https://www.six-group.com/dam/download/financial-information/data-center/iso-currrency/lists/list_one.xml moved to: https://www.six-group.com/dam/download/financial-information/data-center/iso-currrency/lists/list-one.xml

In regards to #4, they also offer a list of historic denominations at https://www.six-group.com/dam/download/financial-information/data-center/iso-currrency/lists/list_three.xml moved to: https://www.six-group.com/dam/download/financial-information/data-center/iso-currrency/lists/list-three.xml

(I have taken an interest because this package lists ZWL as deprecated when it's otherwise still in the official list, including on Wikipedia -- so it seems less ambiguity is needed)

@alcohol
Copy link
Owner

alcohol commented Sep 14, 2022

Yes, though I can't quite say what I would like this to look like. But I am definitely open to scripted updating. If you can start with a PR with some very basic things, I can perhaps provide early feedback.

@alcohol
Copy link
Owner

alcohol commented Sep 14, 2022

I also am still not sure if I want to make this library more in line with how I setup https://github.com/thephpleague/iso3166 or not (I sometimes prefer the more "simple" approach I still have here).

@alcohol
Copy link
Owner

alcohol commented Mar 20, 2023

It would probably be best if the update script could dump the parsed xml contents into a generated file with php code (e.g. <?php return [...];) to allow for opcode caching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants