small::string::substr causes crash

[frank-aurich]

The problem

Calling small::string::substr(pos, count) with a count value larger than the size of the string causes a segfault.
According to the documentation, if count is larger than the size of the string, the function should return the substring from pos to the end of the string.
This is how std::string::substr() behaves.

Steps to Reproduce

#include <small/string.hpp>

template<typename T>
std::vector<T>
b_split(const T& str, const std::string_view& delims)
{
   std::vector<T> output;
   size_t first = 0;

   while (first < str.size())
   {
      const auto second = str.find_first_of(delims, first);

      if (first != second)
      {
         output.emplace_back(str.substr(first, second-first));
      }

      if (second == std::string::npos)
         break;

      first = second + 1;
   }

   return output;
}

int
main()
{
   using namespace std::literals;

   const char inputStr[] = "This is a ctest";

   const auto res = b_split<std::string>(inputStr, " "sv); // OK
   assert(res.size() == 4);

   const auto res2 = b_split<small::string>(inputStr, " "sv); // Crash
   assert(res.size() == 4);

   return 0;
}

Output

The app crashes with a segfault when using small::string.

Platform

• cross-platform issue - linux
• cross-platform issue - windows
• cross-platform issue - macos
• other: ___________

Environment Details

• OS: Windows 10
• OS Version: 22H
• Compiler: Visual Studio 2022
• Compiler version: 17.6.4

Proposed solution

Alternatives I've considered

Additional context