Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize connection timeout #5

Open
diegoparrilla opened this issue Oct 19, 2018 · 1 comment
Open

Customize connection timeout #5

diegoparrilla opened this issue Oct 19, 2018 · 1 comment

Comments

@diegoparrilla
Copy link

Hi there,

I'm trying to use the library to perform massive queries to DNS servers, so customizing the timeout is critical. I had to modify the code and change the TIMEOUT constant in resolver.py, but I was wondering if there is a better way to do it. If not, does it make sense to modify the lookup method to allow an optional timeout parameter? Would you accept a PR with this change?

@al45tair
Copy link
Owner

I think it would either need to be added to the lookup method as an optional argument, or alternatively as a class method on the various Resolver objects. Yes, in principle I'd accept a PR; obviously I'd look through it before merging, and I have been known to write my own changes in response to someone's PR too, so…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants