Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this a small error in the README file? #17

Open
ramiro opened this issue Aug 30, 2018 · 0 comments
Open

Is this a small error in the README file? #17

ramiro opened this issue Aug 30, 2018 · 0 comments

Comments

@ramiro
Copy link

ramiro commented Aug 30, 2018

First of all, this project is a great idea. Thanks!

From https://github.com/akaariai/django-reverse-unique/blame/f0dd7c01ae8ed6193a7ee26b7f4e4195ae42dadd/README.rst#L59-L60

current_salary = models.ReverseUnique(
    "EmployeeSalary",
    filter=Q(valid_from__gte=datetime.now) &
           (Q(valid_until__isnull=True) | Q(valid_until__lte=datetime.now))
)

aren't the valid_from and valid_until filters swapped so we can actually an employee's current salary?

current_salary = models.ReverseUnique(
    "EmployeeSalary",
    filter=Q(valid_from__lte=datetime.now) &
           (Q(valid_until__isnull=True) | Q(valid_until__gte=datetime.now))
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant