Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump git-commit-id-maven-plugin to 7.0.0 to fix git worktree issue #385

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

xkrogen
Copy link
Contributor

@xkrogen xkrogen commented Nov 2, 2023

Bump git-commit-id-maven-plugin to version 7.0.0, which most notably fixes an issue where the plugin doesn't work properly in Git worktrees. See trinodb/trino#18027 for more details on the issue. This will allow consumers to get rid of workarounds like the one introduced to Trino in trinodb/trino#18046

@xkrogen
Copy link
Contributor Author

xkrogen commented Nov 12, 2023

@wendigo @electrum Would one of you be able to take a look at this (or recommend someone else to review)?

@xkrogen
Copy link
Contributor Author

xkrogen commented Nov 29, 2023

Bump @wendigo @electrum in case either of you have a chance to review

@xkrogen
Copy link
Contributor Author

xkrogen commented Dec 14, 2023

Bump again @wendigo @electrum :)

@wendigo
Copy link
Contributor

wendigo commented Dec 14, 2023

@xkrogen David is on vacation and I'm not maintainer here :(

@xkrogen
Copy link
Contributor Author

xkrogen commented Dec 14, 2023

Ah my mistake @wendigo ! I saw your name on a last of past commits and just assumed.

I'll check back in the new year :) Thanks!

@martint martint merged commit 07eb20a into airlift:master Dec 14, 2023
@xkrogen xkrogen deleted the xkrogen/git-commit-id-bump branch December 14, 2023 18:35
@xkrogen
Copy link
Contributor Author

xkrogen commented Dec 14, 2023

Thanks @martint !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants