Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 for existing pages #446

Open
rin opened this issue May 11, 2020 · 5 comments
Open

404 for existing pages #446

rin opened this issue May 11, 2020 · 5 comments
Assignees

Comments

@rin
Copy link

rin commented May 11, 2020

I guess this is more of a discussion …

How do the 404s happen that get reported on Bugnsag – I'm guessing there's not really a problem here and it's just now next.js works?
But … how?
Can we make these not throw Bugsnags in some way?

Bugsnag examples:
https://app.bugsnag.com/aime-mentoring/website-frontend/errors/5ea8f4dff561130017a8c30c?filters[event.since][0]=30d&filters[error.status][0]=open

https://app.bugsnag.com/aime-mentoring/website-frontend/errors/5de1129a37d6bf00185d83ea?filters[event.since][0]=30d&filters[error.status][0]=open

@rin
Copy link
Author

rin commented May 11, 2020

@kbardi I'm guessing this is more in your area of expertise :)

@rin
Copy link
Author

rin commented May 25, 2020

@camposcristianeze @kbardi Any insights on this?

@camposcristian
Copy link
Contributor

How do the 404s happen that get reported on Bugnsag – I'm guessing there's not really a problem here and it's just now next.js works?

@rin I guess is not next.js but just us reporting 404s AND errors using the same page?

bugsnagClient.notify(new Error('Page not found (404)'), {
beforeSend: (report) => {
/* eslint no-param-reassign: "off" */
report.severity = 'info';
report.groupingHash = Router.pathname;
if (isClientSide()) {
report.metaData = {
request: { referer: document.referrer },
};
}
/* eslint no-param-reassign: "error" */
},

I created this issue to explore some solutions, but actually I think we need some sort of threshold (let's say, 100 404 hits?) on either server-side (remember server.js now is ignored with static rendering) and/or bugsnag. Maybe there's a way there to divide 404s instead of grouping them into the same "error"?

@rin
Copy link
Author

rin commented Jun 1, 2020

this issue

@rin I guess is not next.js but just us reporting 404s AND errors using the same page?
Hmm, I'm confused… do we really? So you mean the actual error is NOT a 404 but something else, but it get's caught and reported by the 404?
We have an ErrorBoundary component that should do that …?
cc @kbardi

@camposcristian
Copy link
Contributor

@kbardi would be great If you can take a look during this week 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants