-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test with schedulers and MPI #4
Comments
Scheduler testing framework is hopefully soon in place as well which makes testing this a bit easier: aiidateam/aiida-core#3805. |
As far as I can see, mpi currently cannot work because:
I have opened #47 that simply replaces these two lines by a direct call to the remote executable, which makes it possible to run executables through mpirun ( In order for the same approach to work with multiple processes, It's not clear to me whether it is necessary to introduce this complexity, and perhaps there are easier ways, like getting AiiDA to always run the mock code without mpi, and forward the request to do MPI via an environment variable. @greschd Let me know what you think. |
Hmm, I think the best solution here depends on what comes of our discussion to hook into AiiDA before the code is actually being called (in #43). If the mock-code doesn't actually need to be a standalone executable, these problems would go away. |
The code is currently tested with (and designed for) a direct, non-MPI calculation only. We should test if it works also with schedulers and MPI.
The text was updated successfully, but these errors were encountered: