-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stable release 2.3.0: what is missing? #670
Comments
There's a 2.3.0 milestone that I created https://github.com/aiidalab/aiidalab-widgets-base/milestone/6. I think at minimum we need to relax ASE constraint that was added due to a failing test, see #612. If you could take care of that that would be great. My ambition was also to get rid of some heavy dependencies, in particular pandas, per #591, since I wanted to try and use the 2.3.0 for an integration into the base AiiDAlab image (see exploratory PR in aiidalab/aiidalab-docker-stack#483). I can try find time this week to see how much work in would be (it shouldn't be much). Otherwise I agree that it would be good to release soon. |
I've moved the remaining items to the 2.4 milestone. I think we can go ahead with the release, but I think it needs testing in QeApp, especially features related to ASE (since we unpinned its version) and povray rendering in the StructureViewer widget. cc @edan-bainglass @superstar54 (note: when testing make sure you re-install ASE to the latest version) |
Did a quick testing in my app. Structures rendering works as expected. |
All seems good on my end. Ran full relaxation + bands + pdos on Diamond. Seems good. Structures (crystal and electronic) all look good! |
Shall we? If that's ok, I would like to try the full workflow, as I've never done it. |
Go ahead! |
I guess we have accumulated quite several things for the 2.3.0. To me, it is time to release it.
Are there things that we still want to merge in and need some work?
The text was updated successfully, but these errors were encountered: