Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove console.* messages from lib or mask it under a debug mode flag #152

Open
2 tasks
Tracked by #138
abose opened this issue Feb 28, 2023 · 0 comments
Open
2 tasks
Tracked by #138

remove console.* messages from lib or mask it under a debug mode flag #152

abose opened this issue Feb 28, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@abose
Copy link
Member

abose commented Feb 28, 2023

We should not log any error messages from the lib directly as it will lead to too many logs. Eg. https://github.com/aicore/libmysql/blob/main/src/utils/db.js#L285

there are two alternatives:

  • Remove all console.error calls, and reject with a {stack and error code}. This will help the receiver decide weather to log it or not.
  • Provide a debug flag during init. or a mix of both.

Related to:

@abose abose added the bug Something isn't working label Feb 28, 2023
@abose abose changed the title remove console.* messages from lib or mask it under a debug more flag remove console.* messages from lib or mask it under a debug mode flag Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant