Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression data folders can be merged #281

Open
mcgibbon opened this issue Aug 17, 2022 · 0 comments
Open

Regression data folders can be merged #281

mcgibbon opened this issue Aug 17, 2022 · 0 comments
Labels
refactor Code clean up or deeper refactoring tasks

Comments

@mcgibbon
Copy link
Collaborator

mcgibbon commented Aug 17, 2022

Currently we generate separate data folders for dycore, initialization, and physics regression data. This was done because we must generate these datasets in separate runs, and it is not feasible to merge Serialbox datasets. Now that we convert Serialbox data to netcdf, we could merge this data into a single folder.

Merging these folders would avoid needing to specify TARGET values when running tests, which currently can cause tests to pass without running.

This also requires removing our last dependency on Serialbox so that we can stop archiving Serialbox data. The "serialbox" initialization of the driver must be updated to use netCDF data.

@FlorianDeconinck FlorianDeconinck added the refactor Code clean up or deeper refactoring tasks label Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code clean up or deeper refactoring tasks
Projects
None yet
Development

No branches or pull requests

2 participants