From 1519029b4f72cf8340df13a1a62575c3ccd3789a Mon Sep 17 00:00:00 2001 From: Pran Thomas Date: Fri, 1 Dec 2023 21:14:21 -0800 Subject: [PATCH] upgrade mysql_async from v030.0 to v0.31.2 to fix parse errors Summary: D50506429 upgraded mysql_async to v0.30. With that version of the crate, the asic license_monitor stopped working with the following error: ``` fbcode/asic/license/monitor/xdb/lib.rs:212] failed to update features: failed to update features for vendor synopsys Nov 28 11:10:08 ash-edalic-arvr-snps01.thefacebook.com license_monitor[2041048]: Caused by: Nov 28 11:10:08 ash-edalic-arvr-snps01.thefacebook.com license_monitor[2041048]: 0: failed to delete existing features Nov 28 11:10:08 ash-edalic-arvr-snps01.thefacebook.com license_monitor[2041048]: 1: failed to get MySQL connection Nov 28 11:10:08 ash-edalic-arvr-snps01.thefacebook.com license_monitor[2041048]: 2: failed to get MySQL connection Nov 28 11:10:08 ash-edalic-arvr-snps01.thefacebook.com license_monitor[2041048]: 3: Input/output error: Input/output error: can't parse: buf doesn't have enough data Nov 28 11:10:08 ash-edalic-arvr-snps01.thefacebook.com license_monitor[2041048]: 4: Input/output error: can't parse: buf doesn't have enough data Nov 28 11:10:08 ash-edalic-arvr-snps01.thefacebook.com license_monitor[2041048]: 5: can't parse: buf doesn't have enough data ``` Unfortunately, the change logs and issue tracker on github are not clear. [mysql_async v0.31.2](https://github.com/blackbeam/mysql_async/releases/tag/v0.31.2) addressed this [issue](https://github.com/blackbeam/mysql_async/issues/219) despite what the comments say. Both that issue and the release refer to a conversation on [glitter](https://matrix.to/#/!rVBiivVGEBsRPFFerK:gitter.im/$CkNiRgwTwUthqxdYM5khT12BJ3pLxfSZC0CCfbMANQo?via=gitter.im&via=matrix.org). Putting the pieces together, this issue was addressed by that release. I tested the license_monitor with mysql_async v0.31.2 and the issue went away. Reviewed By: boalinlai Differential Revision: D51636756 fbshipit-source-id: 5eef00637a6ff1b573e4cf2aa1b7324db0262a63 --- shed/sql/Cargo.toml | 2 +- shed/sql/common/Cargo.toml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/shed/sql/Cargo.toml b/shed/sql/Cargo.toml index ada6cdf0b..875db72b5 100644 --- a/shed/sql/Cargo.toml +++ b/shed/sql/Cargo.toml @@ -17,7 +17,7 @@ frunk = "0.4.2" futures = { version = "0.3.28", features = ["async-await", "compat"] } futures-util = "0.3.7" futures_ext = { version = "0.1.0", path = "../futures_ext" } -mysql_async = "0.30.0" +mysql_async = "0.31.2" mysql_common = { version = "0.29.0", features = ["chrono", "default"] } rusqlite = { version = "0.29.0", features = ["backup", "blob", "column_decltype", "limits"] } sql_common = { version = "0.1.0", path = "common" } diff --git a/shed/sql/common/Cargo.toml b/shed/sql/common/Cargo.toml index ba612edc2..c57c696a6 100644 --- a/shed/sql/common/Cargo.toml +++ b/shed/sql/common/Cargo.toml @@ -20,7 +20,7 @@ cloned = { version = "0.1.0", path = "../../cloned" } futures = { version = "0.3.28", features = ["async-await", "compat"] } futures_stats = { version = "0.1.0", path = "../../futures_stats" } itertools = "0.11.0" -mysql_async = "0.30.0" +mysql_async = "0.31.2" mysql_derive = { version = "0.1.0", path = "../derive" } rusqlite = { version = "0.29.0", features = ["backup", "blob", "column_decltype", "limits"] } stats = { version = "0.1.0", path = "../../stats" }