New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syncer must configure finalized Block from reorg detector attached. #176

Open

joanestebanr opened this issue Jan 30, 2025 · 0 comments

Assignees

Labels

Contributor

joanestebanr commented Jan 30, 2025

Syncer must ask for finalized block to the reorg detector attached instead of hardcoded value (

aggkit/cmd/run.go

Line 542 in e141db2

etherman.LatestBlock,

) :
- This allow a more compact configuration
- The reorg detector + syncer is going to be in the same page
The rorg detector must have this value in configuration
- In some cases L2 RPC doesn't have the 'finalized' Block as L2 and returns always a 0.

Also must be a way to disable reorg detector and the code on evmdownloader that request for latest FinalizedBlock.

joanestebanr added the enhancement label

joanestebanr self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment