Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move custom meddlers and meddler initialization to a common repo #166

Open
goran-ethernal opened this issue Jan 24, 2025 · 0 comments
Open

Comments

@goran-ethernal
Copy link
Contributor

goran-ethernal commented Jan 24, 2025

We had an issue where two components in different repos (cdk and zkevm-ethtx-manager) have their own initialization of meddler for sqlite, which were different for HashMeddler. aggsender introduced an additional logic in the HashMeddler for handling nullable hash fields, which zkevm-eth-txmanager did not have, so when cdk node was run with both eth-txmanager and aggsender, the eth-txmanager initialized meddler with its own custom meddlers, which resulted in unsuccessful saving of new certificates to the sqlite db, since meddler is a global instance in the app, and it can be initialized only once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant