Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect cockpit permissions #14

Open
lucalanca opened this issue Feb 27, 2019 · 2 comments
Open

Respect cockpit permissions #14

lucalanca opened this issue Feb 27, 2019 · 2 comments

Comments

@lucalanca
Copy link

lucalanca commented Feb 27, 2019

Current

It seems that the token parameter is always needed when getting data. Even if the requested data has public visibility.

Expected

  1. The token is only required when needed. If all the queries have public visibility, then the token is not required.
@gryphonmyers
Copy link

Additional data: permissions logic added to the collection (via the CRUD code editor fields under Permissions tab) is not respected when querying via cockpitql. This is a security concern, as potentially sensitive data could be exposed on the cockpitql endpoint.

@gryphonmyers
Copy link

@aheinze This seems pretty critical for production use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants