Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imports of modules that have current module name as prefix are dropped silently #338

Closed
jespercockx opened this issue Jul 11, 2024 · 0 comments · Fixed by #380
Closed

Imports of modules that have current module name as prefix are dropped silently #338

jespercockx opened this issue Jul 11, 2024 · 0 comments · Fixed by #380
Assignees
@jespercockx
Labels
bug Something isn't working
Milestone
1.4

Comments

@jespercockx
Copy link
Member

If I have a module AAA that imports another module AAABBB, then this import is dropped from the generated Haskell code. The cause is located here:

agda2hs/src/Agda2Hs/Compile/Imports.hs

Line 28 in 0fc20cc

let is = filter (not . (top `isPrefixOf`) . Hs.prettyPrint . importModule) is0

(Git blame tells me I have no-one to blame except for myself.)
@jespercockx jespercockx added the bug Something isn't working label Jul 11, 2024
jespercockx added a commit to jespercockx/agda2hs that referenced this issue Jul 11, 2024
@jespercockx
[ fix agda#338 ] Only filter out imports of current module, not other…
3478a21 
… modules with current module as prefix
@jespercockx jespercockx added this to the 1.4 milestone Oct 31, 2024
jespercockx added a commit to jespercockx/agda2hs that referenced this issue Dec 13, 2024
@jespercockx
[ fix agda#338 ] Only filter out imports of current module, not other…
cf6c980 
… modules with current module as prefix
@jespercockx jespercockx linked a pull request Dec 13, 2024 that will close this issue
Fix #324: Keep track of instance-only imports #380
Merged
@jespercockx jespercockx self-assigned this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jespercockx jespercockx

Labels
bug Something isn't working
Projects
None yet
Milestone
1.4
Development

Successfully merging a pull request may close this issue.

Fix #324: Keep track of instance-only imports jespercockx/agda2hs
1 participant
@jespercockx