From 7236b29ee6187ce5236d66ba9f8ef826c9f73141 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Beno=C3=AEt=20L=C3=A9v=C3=AAque?= Date: Sat, 24 Aug 2024 15:04:37 +0200 Subject: [PATCH] correct checkstyle --- src/Campaign/ResponseFactory.php | 4 +--- src/Filter/JobTitleFilter.php | 3 ++- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/Campaign/ResponseFactory.php b/src/Campaign/ResponseFactory.php index 2393db78..467a3852 100644 --- a/src/Campaign/ResponseFactory.php +++ b/src/Campaign/ResponseFactory.php @@ -133,9 +133,7 @@ public function createResponse(array $data, Campaign $campaign): Response foreach ($enumValues as $field => $enum) { $enumClass = $this->enums->getEnums($enum['class']); $enumId = $enumClass->getIdByLabel($data[$enum['key']] ?? null); - if ($field === 'PhpVersion' && 0 === $enumId) { - dump($data[$enum['key']] ?? null, '---'); - } + if ($enumClass instanceof JobTitleEnums && 0 === $enumId) { $enumId = $enumClass->oldChoices[$data[$enum['key']]] ?? 0; } diff --git a/src/Filter/JobTitleFilter.php b/src/Filter/JobTitleFilter.php index 11f555ec..cc4bfb93 100644 --- a/src/Filter/JobTitleFilter.php +++ b/src/Filter/JobTitleFilter.php @@ -54,7 +54,7 @@ private function supportOldValues(array $values): array JobTitleEnums::DEV_JUNIOR, JobTitleEnums::DEV_CONFIRME, JobTitleEnums::DEV_SENIOR, - JobTitleEnums::DEV_EXPERT + JobTitleEnums::DEV_EXPERT, ]; $oldTitle = [ @@ -65,6 +65,7 @@ private function supportOldValues(array $values): array if ([] !== array_intersect($values, $mapping)) { $values = array_merge($values, $oldTitle); } + return $values; }