Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading screen while assets download and entities load #779

Closed
ngokevin opened this issue Jan 13, 2016 · 7 comments
Closed

Support loading screen while assets download and entities load #779

ngokevin opened this issue Jan 13, 2016 · 7 comments

Comments

@ngokevin
Copy link
Member

Issue by cvan
Friday Dec 18, 2015 at 22:45 GMT
Originally opened as https://github.com/aframevr/aframe-core/issues/718


Per https://twitter.com/footedesign/status/677967278890221570

@ngokevin
Copy link
Member Author

Comment by ngokevin
Friday Dec 18, 2015 at 23:54 GMT


depends on adding asset blocking to <a-assets> before it fires loaded.

then users than listen on loaded and manage loading screens however they want.

@ngokevin
Copy link
Member Author

Comment by cvan
Friday Dec 18, 2015 at 23:59 GMT


@ngokevin but in the case of external URLs that get loaded from material component and then from THREE.js's loaders, we can handle those today without changing making <a-assets> inert (which we could do, but then we'd have to enable some like preload boolean).

@ngokevin
Copy link
Member Author

Comment by ngokevin
Saturday Dec 19, 2015 at 00:00 GMT


i think we intend if you don't put it in assets there is no preloading/blocking logic.

right now a-assets does nothing. we should enforce through a-assets because that is canonical, anyone can make a material component.

@ngokevin
Copy link
Member Author

Comment by cvan
Saturday Dec 19, 2015 at 00:02 GMT


i think we intend if you don't put it in assets there is no preloading/blocking logic.

yeah, I know - basically what this issue is for is to introduce some type of events (perhaps assetsstart, assetsprogress, and assetsend or something) for materials on entities and models to know when the asset(s) have been actually loaded.

@ngokevin
Copy link
Member Author

Comment by ngokevin
Saturday Dec 19, 2015 at 00:04 GMT


Yeah we'd add events. But wouldn't have to touch the material component itself

@ngokevin
Copy link
Member Author

Comment by cvan
Saturday Dec 19, 2015 at 00:07 GMT


Yeah we'd add events. But wouldn't have to touch the material component itself

correct, just the loadImage, loadVideo, etc. functions in that file

ngokevin added a commit to ngokevin/aframe that referenced this issue Jan 27, 2016
ngokevin added a commit to ngokevin/aframe that referenced this issue Jan 28, 2016
ngokevin added a commit to ngokevin/aframe that referenced this issue Jan 28, 2016
ngokevin added a commit to ngokevin/aframe that referenced this issue Feb 1, 2016
ngokevin added a commit to ngokevin/aframe that referenced this issue Feb 1, 2016
ngokevin added a commit to ngokevin/aframe that referenced this issue Feb 1, 2016
ngokevin added a commit to ngokevin/aframe that referenced this issue Feb 3, 2016
dmarcos added a commit that referenced this issue Feb 3, 2016
block render loop on assets (fixes #873, #367, #779)
@ngokevin
Copy link
Member Author

ngokevin commented Feb 3, 2016

Now supported. #925 is a bit more specific

@ngokevin ngokevin closed this as completed Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant