-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fair number of community registry packages aren't working right now. #59
Comments
Thanks. Hmm, how did you test them, via Inspector? Not sure curation can be automated, but it's a lot of work. |
Hmm maybe in the future, a way of reporting broken components on the Registry |
Yeah, I just opened the inspector and tried to add those components. I think we could automate a test ensuring that the dist file exists (which was the problem for at least two of these), but the JS errors seem harder to catch. |
OK, ensuring the dist sounds easy at least. I'm not sure if through the Inspector is a common way to consume components anymore, so some of them might not be set up to work on Inspector. |
What do you mean by 'set up to work on inspector'? I guess some of mine do export something like: AFRAME.registerComponent('foo', {...}); .... which assumes that AFRAME is in the global scope, and would break for webpacked sites. |
For example |
Oh I see, makes sense. |
It seems |
I just tested a couple from the A-Frame homepage:
leap-hands(items crossed out are now fixed)
That
leap-hands
is broken is my own fault; I ignored thedist
folder in.npmignore
. The others seem to have various issues, some missing on NPM, some throwing JavaScript errors.Not sure how feasible it would be to test entries in an automated way.
The text was updated successfully, but these errors were encountered: