Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fair number of community registry packages aren't working right now. #59

Open
1 of 6 tasks
donmccurdy opened this issue Mar 30, 2017 · 8 comments
Open
1 of 6 tasks

Comments

@donmccurdy
Copy link
Member

donmccurdy commented Mar 30, 2017

I just tested a couple from the A-Frame homepage:

  • leap-hands
  • audio-analyzer
  • firebase
  • firebase-broadcast
  • json-model
  • mountain

(items crossed out are now fixed)

That leap-hands is broken is my own fault; I ignored the dist folder in .npmignore. The others seem to have various issues, some missing on NPM, some throwing JavaScript errors.

Not sure how feasible it would be to test entries in an automated way.

@ngokevin
Copy link
Member

Thanks. Hmm, how did you test them, via Inspector?

Not sure curation can be automated, but it's a lot of work.

@ngokevin
Copy link
Member

Hmm maybe in the future, a way of reporting broken components on the Registry

@donmccurdy
Copy link
Member Author

Yeah, I just opened the inspector and tried to add those components. I think we could automate a test ensuring that the dist file exists (which was the problem for at least two of these), but the JS errors seem harder to catch.

@ngokevin
Copy link
Member

OK, ensuring the dist sounds easy at least. I'm not sure if through the Inspector is a common way to consume components anymore, so some of them might not be set up to work on Inspector.

@donmccurdy
Copy link
Member Author

donmccurdy commented Mar 30, 2017

What do you mean by 'set up to work on inspector'? I guess some of mine do export something like:

AFRAME.registerComponent('foo', {...});

.... which assumes that AFRAME is in the global scope, and would break for webpacked sites.

@ngokevin
Copy link
Member

For example firebase components aren't really Inspector friendly, not tested there. I do have the inspector: false option, but that's not listened to by Inspector yet.

@donmccurdy
Copy link
Member Author

Oh I see, makes sense.

@fernandojsg
Copy link
Member

It seems alongpath doesn't work either aframevr/aframe-inspector#464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants