Skip to content
This repository has been archived by the owner on May 31, 2019. It is now read-only.

Labels containing a space sign are improperly encoded in the Totp.uri method output #21

Open
divarvel opened this issue Aug 17, 2016 · 1 comment

Comments

@divarvel
Copy link

UrlEncoder encodes spaces as + instead of %20, which is consistent with application/x-www-form-urlencoded and OK in query strings, but causes an error if it's in other components.

A solution would be to use java.net.URI to build the uri. I can write a PR if needed.

@tovine
Copy link

tovine commented Jan 25, 2018

I too got bitten by this today. Technically it should be fixed in the URLEncoder class, but as long as the Java library implementation isn't fully standard compliant you should implement a suitable workaround.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants