change protobuf specification ( file name ) #257
Closed
rabbitprincess
started this conversation in
Show and tell
Replies: 1 comment 4 replies
-
OK, no problem Is there a sync test running for the changes on gRPC? Is the update of libp2p included on sync test? Will it solve all the 4 issues from dependabot? |
Beta Was this translation helpful? Give feedback.
4 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
To update the Protobuf and gRPC versions, there must not be the same proto file name.
However, the filename "raft.proto" is duplicated within the etcd repository.
Therefore, I renamed the "raft.go" file to "aergo_raft.go." You can find the updated files at this link: https://github.com/aergoio/aergo-protobuf/tree/topic/update-dependency.
It appears that changing the file name will not result in any unexpected issues.
But, after it is merged into the main branch, all repositories using Protobuf should be updated accordingly.
Beta Was this translation helpful? Give feedback.
All reactions