From fca42bfbf7443c1721f382201cf12dc17c3ff841 Mon Sep 17 00:00:00 2001 From: Andrew Stacy Date: Thu, 12 Sep 2024 14:09:37 -0400 Subject: [PATCH] revert: reverts the perf change removing date-fns as it resulted in negligible savings --- package.json | 2 +- src/formatters/formatter.ts | 2 +- src/formatters/json/json.ts | 2 +- src/formatters/standard/standard.ts | 2 +- src/functions/data.ts | 26 -------------------------- 5 files changed, 4 insertions(+), 30 deletions(-) diff --git a/package.json b/package.json index 68ae1b1..733ef87 100644 --- a/package.json +++ b/package.json @@ -63,7 +63,6 @@ "@vuepress/theme-default": "^2.0.0-rc.11", "commitizen": "^4.3.0", "cz-conventional-changelog": "^3.3.0", - "date-fns": "^3.6.0", "eslint": "^8.57.0", "eslint-config-prettier": "^9.1.0", "happy-dom": "^15.7.3", @@ -87,6 +86,7 @@ "**/*.{js,ts}": "eslint --fix" }, "dependencies": { + "date-fns": "^3.6.0", "chalk": "^5.3.0", "vuepress-plugin-search-pro": "^2.0.0-rc.52" }, diff --git a/src/formatters/formatter.ts b/src/formatters/formatter.ts index 109b968..990f097 100644 --- a/src/formatters/formatter.ts +++ b/src/formatters/formatter.ts @@ -1,4 +1,4 @@ -import { formatISO } from '../functions'; +import { formatISO } from 'date-fns/formatISO'; import { LevelConfiguration, ModifierData } from '../_types'; import { Configuration } from '../configuration'; import { diff --git a/src/formatters/json/json.ts b/src/formatters/json/json.ts index 6ba631b..0735d76 100644 --- a/src/formatters/json/json.ts +++ b/src/formatters/json/json.ts @@ -1,6 +1,6 @@ import Formatter from '../formatter'; import { ModifierData } from '../../_types'; -import { formatISO } from '../../functions'; +import { formatISO } from 'date-fns/formatISO'; import { JsonLog, JsonLogOptionalFields, JsonLogRequiredFields } from './types'; import { hasRequiredFields } from './type-guards'; import { setup } from '../../functions'; diff --git a/src/formatters/standard/standard.ts b/src/formatters/standard/standard.ts index 551dc84..a7a62c2 100644 --- a/src/formatters/standard/standard.ts +++ b/src/formatters/standard/standard.ts @@ -1,6 +1,6 @@ import Formatter from '../formatter'; import { ModifierData } from '../../_types'; -import { formatISO } from '../../functions'; +import { formatISO } from 'date-fns/formatISO'; import { isNumber, isObject, isString } from '../../functions'; /** diff --git a/src/functions/data.ts b/src/functions/data.ts index 9c9f482..732f3ab 100644 --- a/src/functions/data.ts +++ b/src/functions/data.ts @@ -33,29 +33,3 @@ export function getActiveLevel(cfg: Configuration): number { export function leadingZero(num: number): string { return (num < 10 ? '0' : '') + `${num}`; } - -/** - * Returns an ISO-8601 formatted string from the provided date. - */ -export function formatISO(date: Date) { - const tzo = -date.getTimezoneOffset(); - const dif = tzo >= 0 ? '+' : '-'; - - return ( - `${date.getFullYear()}` + - '-' + - leadingZero(date.getMonth() + 1) + - '-' + - leadingZero(date.getDate()) + - 'T' + - leadingZero(date.getHours()) + - ':' + - leadingZero(date.getMinutes()) + - ':' + - leadingZero(date.getSeconds()) + - dif + - leadingZero(Math.floor(Math.abs(tzo) / 60)) + - ':' + - leadingZero(Math.abs(tzo) % 60) - ); -}