-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more string tests for IndexOf and utf-8 #11
Comments
Utf-8 specifics are affecting any method that:
for AGS 3.*:
for AGS 4.*:
|
ok, I added a few tests, but I also found a small bug in the new compiler. ags-test-games/ags4/auto-test/test-string.asc Lines 16 to 20 in 7d909cb
This gives the error "test-string.asc(19): Expected a quote mark but found '¤' instead". |
I think some string UpperCase/LowerCase tests would be useful to have by just having a few strings with characters from different alphabets - like lower/upper of Greek, and so on. |
I cannot remember what happened when I tested unicode char literals. But they are supposed to work, at least with the new compiler which is more advanced. |
Sure, I will create a proper bug report later. To be specific this is only a bug in the new compiler, it works fine in the old one. |
IndexOf could use a few additional utf-8 tests to ensure we are correctly getting the right index when either or both the string and needle have utf-8 characters.
There are probably other utf-8 tests that would be useful to add to strings but I don't remember right now any other cases.
The text was updated successfully, but these errors were encountered: