Nit: tests for pointers in structs

[Miles-Garnsey]

There are tests for structs here. It might be good to see some tests for structs which contain pointer fields.

[adutra]

Hi @Miles-Garnsey, in fact TestCoalesce is not meant to cover all possible cases extensively – if it were, it would become insanely huge.

Instead, I chose to only put a few smoke tests there.

In struct_test.go, you have many tests exercising pointer fields, see here.

I will add a comment to TestCoalesce – in fact I should have done that from the beginning.

[Miles-Garnsey]

Ah, I see, that does make sense.

I think it might be worth thinking about where the tests are placed, since (as well as my confusion on the struct tests) I got a bit confused over them being split between atomic_test.go and pointer_test.go and had to go hunting for some particular cases.

It might be worth thinking about having a layered approach where we move some of the existing unit tests out into integration tests (especially where the tested behaviour relies on a fallback coalescer that sits outside the unit).

I don't know if that's a task for right now though, seems like a low priority.