Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overload lu on matrices of tracers #138

Closed
adrhill opened this issue Jun 26, 2024 · 1 comment
Closed

Overload lu on matrices of tracers #138

adrhill opened this issue Jun 26, 2024 · 1 comment
Labels
array Features regarding array overloads bug Something isn't working new overloads A new method on tracers is required by a user.

Comments

@adrhill
Copy link
Owner

adrhill commented Jun 26, 2024 •
edited
Loading

When using sparse matrices of tracers, lu calls itself, causing a stack overflow:

lu(A::AbstractSparseMatrixCSC; check::Bool = true) = lu(float(A); check = check)

This is due to us "abusing" float to return a tracer.

Overloading lu would avoid this issue. Ideally, this should be done for both "regular" and sparse matrices.

Related issue: #108
@adrhill adrhill added bug Something isn't working enhancement New feature or request array Features regarding array overloads and removed enhancement New feature or request labels Jun 26, 2024
@adrhill adrhill added the new overloads A new method on tracers is required by a user. label Aug 7, 2024
@gdalle gdalle mentioned this issue Sep 6, 2024
Closed
@adrhill
Copy link
Owner Author

adrhill commented Oct 21, 2024

Closing, see #192.

@adrhill adrhill closed this as completed Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
array Features regarding array overloads bug Something isn't working new overloads A new method on tracers is required by a user.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adrhill