Add option to build in wsl #4121
Merged
+24
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for creating a pull request! |
|
a --wsl flag would be good :-) |
github-actions
bot
added
the
documentation
Now it should be a --wsl flag! |
Scanteianu
commented
Jan 30, 2025
karianna
approved these changes
Jan 30, 2025
andrew-m-leonard
approved these changes
Jan 31, 2025
|
Thanks both for the reviews, would it be possible to get a squash and merge please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For easy testing.
Open to alternative ways of doing it, adding these params seemed to make the script run end to end in wsl, so I think it would be good to have a way to run the script in wsl mode.
FWIW, I run using
./makejdk-any-platform.sh -J /usr/lib/jvm/java-21-openjdk-amd64 --create-sbom --wsl jdk21