Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenJ9 builds should pass OpenJ9 SHA to test #143

Open
AdamBrousseau opened this issue May 5, 2021 · 2 comments
Open

OpenJ9 builds should pass OpenJ9 SHA to test #143

AdamBrousseau opened this issue May 5, 2021 · 2 comments

Comments

@AdamBrousseau
Copy link
Contributor

For OpenJ9 builds, the openj9 sha used to compile the SDK should be passed to test. Sometimes there are code changes with matching test changes. If such a change is merged "mid-flight" (ie. After a compile starts but before a test starts), the test job would pickup the change and could cause failure. This has happened in eclipse-openj9/openj9#12629 for example.

@zdtsw
Copy link
Contributor

zdtsw commented Sep 15, 2022

is this still a valid issue?

@llxia
Copy link
Contributor

llxia commented Sep 15, 2022

I think this is valid.
In addition, I think we should do a sniff for all test-related repos and pass all test repo SHAs to test builds to ensure we are running the same test materials in one pipeline. Otherwise, we would have a similar problem. If a PR is delivered between test builds, we could end up running different test materials in the same pipeline.

FYI @smlambert

AdamBrousseau added a commit to AdamBrousseau/ci-jenkins-pipelines that referenced this issue Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

5 participants