-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine exclude files logic #5890
Comments
I'd think for OpenJ9 we always have jdk version openjdk specific excludes for any new version. Although perhaps they are temporary while we bring up the new version and when temporary excludes are later removed the exclude list might be the same as the previous version. |
Yes, for openjdk test we always have jdk version-specific excludes. A common exclude file could reduce the work of copying common ones and ensure the test build does not break if version-specific exclude does not exist. The proposed solution is to have a common exclude file + an optional version-specific exclude. This issue is mainly targeted at these duplicated exclude files (no new excludes). Currently, we have to create the file for each version regardless. Otherwise, the test build will break. FYI @JasonFengJ9 |
@LongyuZhang could you work on this one? Let's start with functional tests. There are some details mentioned in eclipse-openj9/openj9#17901 |
New exclude files (for openjdk, functional, etc) have to be created for the new JDK version regardless of whether we have any new changes. See eclipse-openj9/openj9#17901.
I think we should have a common exclude file. A new exclude file only needs to be created if there are any specific excludes for particular JDK version.
The text was updated successfully, but these errors were encountered: