Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine exclude files logic #5890

Open
llxia opened this issue Jan 21, 2025 · 3 comments
Open

Refine exclude files logic #5890

llxia opened this issue Jan 21, 2025 · 3 comments

Comments

@llxia
Copy link
Contributor

llxia commented Jan 21, 2025

New exclude files (for openjdk, functional, etc) have to be created for the new JDK version regardless of whether we have any new changes. See eclipse-openj9/openj9#17901.

I think we should have a common exclude file. A new exclude file only needs to be created if there are any specific excludes for particular JDK version.

@pshipton
Copy link
Contributor

pshipton commented Jan 21, 2025

I'd think for OpenJ9 we always have jdk version openjdk specific excludes for any new version. Although perhaps they are temporary while we bring up the new version and when temporary excludes are later removed the exclude list might be the same as the previous version.

@llxia
Copy link
Contributor Author

llxia commented Jan 22, 2025

Yes, for openjdk test we always have jdk version-specific excludes. A common exclude file could reduce the work of copying common ones and ensure the test build does not break if version-specific exclude does not exist.

The proposed solution is to have a common exclude file + an optional version-specific exclude.

This issue is mainly targeted at these duplicated exclude files (no new excludes). Currently, we have to create the file for each version regardless. Otherwise, the test build will break.
https://github.com/eclipse-openj9/openj9/tree/master/test/functional/cmdLineTests/jvmtitests
https://github.com/eclipse-openj9/openj9/tree/master/test/TestConfig/resources/excludes

FYI @JasonFengJ9

@llxia
Copy link
Contributor Author

llxia commented Jan 31, 2025

@LongyuZhang could you work on this one? Let's start with functional tests. There are some details mentioned in eclipse-openj9/openj9#17901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants