Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New testcase JavacBench.java#dynamic fails on win32 #5870

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

andrew-m-leonard
Copy link
Contributor

Exclude for #5869

jdk17 win32 test runtime/cds/appcds/applications/JavacBench.java#dynamic fails due to no client CDS

@sxa
Copy link
Member

sxa commented Jan 16, 2025

Is the absence of a client CDS a bug or intentional?

@andrew-m-leonard
Copy link
Contributor Author

andrew-m-leonard commented Jan 16, 2025

Is the absence of a client CDS a bug or intentional?

win32 we build client & server
09:14:56 * JVM variants: client server

but CDS images are only built for a server, so this testcase shouldn't be run for a win32 client image.
The testcase comes from a recent backport for jdk-21+ where there is no Win32 and thus only server...

@sophia-guo
Copy link
Contributor

15:01:23  [0.024s][info   ][cds    ] UseSharedSpaces: Unable to map shared spaces
15:01:23  Error occurred during initialization of VM
15:01:23  DynamicDumpSharedSpaces is unsupported when base CDS archive is not loaded
15:01:23  ];

Can't initialization of VM I would say it's testcase issue which should not block the release. As the testcase comes from a recent backport for jdk-21+ where there is no Win32 I would say this exclusion would be a permanent.

@sophia-guo
Copy link
Contributor

@andrew-m-leonard did we have same issue with arm32?

@sophia-guo sophia-guo merged commit 9dcc9a3 into adoptium:master Jan 16, 2025
3 checks passed
andrew-m-leonard added a commit to andrew-m-leonard/aqa-tests that referenced this pull request Jan 17, 2025
sophia-guo added a commit that referenced this pull request Jan 17, 2025
* Exclude hotspot runtime tests on arm linux (#5866)

Signed-off-by: Andrew Leonard <[email protected]>

* Exclude riscv headless failure for tools/jpackage/linux/LinuxWeirdOutputDirTest (#5868)

Signed-off-by: Andrew Leonard <[email protected]>

* Exclude JShellHeapDumpTest for windows-all (#5872)

Signed-off-by: Andrew Leonard <[email protected]>

* New testcase JavacBench.java#dynamic fails on win32 (#5870)

Signed-off-by: Andrew Leonard <[email protected]>
Co-authored-by: sophia-guo <[email protected]>

---------

Signed-off-by: Andrew Leonard <[email protected]>
Co-authored-by: sophia-guo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants