Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick openjdk exclude fixes #5864

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard self-assigned this Jan 16, 2025
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate that this is a cherry pick but since I didn't see the original PR for the beans tests I have a couple of questions:

  1. You seem to have replaced windows-x86 with windows-all. Is that intentional?
  2. For jdk21 it looks like you're merging in the windows and Mac excludes but haven't removed any windows lines so is this a new exclude on that version?

Apologies if I missed something obvious with the above.

@andrew-m-leonard
Copy link
Contributor Author

I appreciate that this is a cheery pick but since I didn't see the original PR for the beans tests I have a couple of questions:

1. You seem to have replaced windows-x86 with windows-all. Is that intentional?

2. For jdk21 it looks like you're merging in the windows and Mac excludes but haven't removed any windows lines so is this a new excluder on that version?
  1. yes, fails in win64 too: January 2025 Dry-run Triage - JDK17 #5852 (comment)
  2. yes, they fail on jdk-21 win64 as well : https://ci.adoptium.net/view/Test_openjdk/job/Test_openjdk21_hs_extended.openjdk_x86-64_windows_rerun/43/console

@andrew-m-leonard andrew-m-leonard requested a review from sxa January 16, 2025 11:46
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@smlambert smlambert merged commit 5a9e525 into adoptium:v1.0.5-release Jan 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants