Correct PropertyEditor exclusion mac+windows excludes under one entry #5863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Leonard <[email protected]>
smlambert
approved these changes
Jan 15, 2025
sophia-guo
approved these changes
Jan 15, 2025
andrew-m-leonard
added a commit
to andrew-m-leonard/aqa-tests
that referenced
this pull request
Jan 16, 2025
…adoptium#5863) Signed-off-by: Andrew Leonard <[email protected]>
smlambert
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Symantec/Distrust exclude renamed for jdk-17+ (#5862) Signed-off-by: Andrew Leonard <[email protected]> * Correct PropertyEditor exclusion mac+windows excludes under one entry (#5863) Signed-off-by: Andrew Leonard <[email protected]> --------- Signed-off-by: Andrew Leonard <[email protected]>
|
If there are more entries only the last one takes effect, which explains why there are still failures in jdk17 mac #5852 (comment). It's better to check this duplicate exclusion in https://github.com/adoptium/aqa-tests/blob/master/scripts/disabled_tests/exclude_parser.py so it can be detected when added initially. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some corrections for existing excludes in jdk17 and jdk21 openjdk excludes for: